Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #1179

Merged
merged 3 commits into from Jul 16, 2022
Merged

Drop support for Python 3.7 #1179

merged 3 commits into from Jul 16, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 19, 2022

Closes #1148.

Should not be merged until we are about to release v0.19.

@ml-evs ml-evs added blocked For issues/PRs that are blocked by required changes/clarifications to the specification. python Pull requests that update Python code on-hold For PRs/issues that are on-hold for an unspecified time for_next_release Issues that need to be dealt with at the next release. labels May 19, 2022
@ml-evs ml-evs added this to the v0.18.0 milestone May 19, 2022
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1179 (a201609) into master (94704f9) will decrease coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
- Coverage   91.16%   90.70%   -0.46%     
==========================================
  Files          72       72              
  Lines        4311     4315       +4     
==========================================
- Hits         3930     3914      -16     
- Misses        381      401      +20     
Flag Coverage Δ
project 90.70% <ø> (-0.46%) ⬇️
validator 90.70% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/__init__.py 100.00% <ø> (+42.85%) ⬆️
optimade/client/client.py 69.51% <0.00%> (-8.97%) ⬇️
optimade/client/cli.py 83.67% <0.00%> (-4.09%) ⬇️
optimade/server/schemas.py 100.00% <0.00%> (ø)
optimade/models/structures.py 95.75% <0.00%> (ø)
optimade/models/utils.py 92.78% <0.00%> (+0.07%) ⬆️
optimade/server/config.py 91.66% <0.00%> (+0.08%) ⬆️
optimade/filtertransformers/elasticsearch.py 85.94% <0.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94704f9...a201609. Read the comment docs.

@ml-evs ml-evs modified the milestones: v0.18.0, v0.19.0 May 24, 2022
@ml-evs ml-evs removed blocked For issues/PRs that are blocked by required changes/clarifications to the specification. on-hold For PRs/issues that are on-hold for an unspecified time labels Jul 16, 2022
@ml-evs ml-evs marked this pull request as ready for review July 16, 2022 22:10
@ml-evs ml-evs merged commit 5fb2d7d into master Jul 16, 2022
@ml-evs ml-evs deleted the ml-evs/drop_py37 branch July 16, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for_next_release Issues that need to be dealt with at the next release. python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.7 support?
2 participants