Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden validator for partially implemented APIs #1181

Merged
merged 4 commits into from
May 21, 2022
Merged

Harden validator for partially implemented APIs #1181

merged 4 commits into from
May 21, 2022

Commits on May 21, 2022

  1. Fix response_fields validation in case page_limit is not implemented

    @ml-evs
    ml-evs committed May 21, 2022
    Configuration menu
    Copy the full SHA
    17340dc View commit details
    Browse the repository at this point in the history

  2. Harden page_limit tests: 

    - Remove CLI control of page_limit and set the default value to
something less common (4)
- Check `next` links for duplicates during pagination
    @ml-evs
    ml-evs committed May 21, 2022
    Configuration menu
    Copy the full SHA
    cf590ac View commit details
    Browse the repository at this point in the history

  3. Do not rely on page_offset for filter tests

    @ml-evs
    ml-evs committed May 21, 2022
    Configuration menu
    Copy the full SHA
    1dbe1f7 View commit details
    Browse the repository at this point in the history

  4. Reorder filter test precedence: 

    - Make sure optional queries don't do an 'allowed failure'
before more important non-optional checks
- Assume that the archetypal entry will always be on the first
page of results (assumes constant default sorting from the API)
rather than allowing bad results to hide in future pages
    @ml-evs
    ml-evs committed May 21, 2022
    Configuration menu
    Copy the full SHA
    cdabed9 View commit details
    Browse the repository at this point in the history