Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom User-Agent with validator #1189

Merged
merged 1 commit into from May 24, 2022
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 24, 2022

Partially supersedes #1188.

Should be straightforward!

@ml-evs ml-evs added the validator Related to the OPTIMADE validator label May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #1189 (37f2d50) into master (4155617) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   92.40%   92.41%           
=======================================
  Files          68       68           
  Lines        3912     3914    +2     
=======================================
+ Hits         3615     3617    +2     
  Misses        297      297           
Flag Coverage Δ
project 92.41% <100.00%> (+<0.01%) ⬆️
validator 92.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/validator/utils.py 94.70% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4155617...37f2d50. Read the comment docs.

@ml-evs ml-evs merged commit afce99c into master May 24, 2022
@ml-evs ml-evs deleted the ml-evs/use_custom_user_agent branch May 24, 2022 12:46
@ml-evs ml-evs linked an issue May 25, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validator Related to the OPTIMADE validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The validator should use a custom User-Agent header
2 participants