Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch connection errors when populating client database list #1197

Merged
merged 1 commit into from May 29, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 29, 2022

Closes #1196.

@ml-evs ml-evs added the client Issues/PRs relating to the OPTIMADE client. label May 29, 2022
@ml-evs ml-evs added the for_next_release Issues that need to be dealt with at the next release. label May 29, 2022
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #1197 (912461c) into master (05a0574) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

❗ Current head 912461c differs from pull request most recent head d81a6c8. Consider uploading reports for the commit d81a6c8 to get more accurate results

@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
- Coverage   91.80%   91.76%   -0.05%     
==========================================
  Files          72       72              
  Lines        4282     4285       +3     
==========================================
+ Hits         3931     3932       +1     
- Misses        351      353       +2     
Flag Coverage Δ
project 91.76% <50.00%> (-0.05%) ⬇️
validator 91.15% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/utils.py 95.23% <50.00%> (-3.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a0574...d81a6c8. Read the comment docs.

@ml-evs ml-evs added the bug Something isn't working label May 29, 2022
@ml-evs ml-evs force-pushed the ml-evs/fix_client_when_providers_are_down branch from d19d706 to 912461c Compare May 29, 2022 20:18
@ml-evs ml-evs force-pushed the ml-evs/fix_client_when_providers_are_down branch from 912461c to d81a6c8 Compare May 29, 2022 20:36
@ml-evs ml-evs changed the title Catch index meta-database errors database list for client Catch connection errors when populating client database list (#1197) May 29, 2022
@ml-evs ml-evs changed the title Catch connection errors when populating client database list (#1197) Catch connection errors when populating client database list May 29, 2022
@ml-evs ml-evs merged commit b6b21b0 into master May 29, 2022
@ml-evs ml-evs deleted the ml-evs/fix_client_when_providers_are_down branch May 29, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issues/PRs relating to the OPTIMADE client. for_next_release Issues that need to be dealt with at the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptimadeClient crashes if an index meta-database is down
1 participant