Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clearer error message on when trying to use client with missing deps #1200

Merged
merged 1 commit into from May 29, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 29, 2022

This PR simply adds an import guard around rich and httpx with a more user-friendly error message.

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #1200 (3e5c9cb) into master (6c2e768) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
- Coverage   91.84%   91.80%   -0.05%     
==========================================
  Files          72       72              
  Lines        4279     4282       +3     
==========================================
+ Hits         3930     3931       +1     
- Misses        349      351       +2     
Flag Coverage Δ
project 91.80% <66.66%> (-0.05%) ⬇️
validator 91.19% <66.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/client/client.py 78.90% <66.66%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c2e768...3e5c9cb. Read the comment docs.

@ml-evs ml-evs force-pushed the ml-evs/add_client_import_guard branch from 2bd7dc4 to 097310e Compare May 29, 2022 19:16
@ml-evs ml-evs force-pushed the ml-evs/add_client_import_guard branch from 097310e to 3e5c9cb Compare May 29, 2022 20:07
@ml-evs ml-evs added ergonomics Features that improve the usability of the package client Issues/PRs relating to the OPTIMADE client. labels May 29, 2022
@ml-evs ml-evs changed the title Add a helpful error message on missing client deps Add a clearer error message on when trying to use client with missing deps May 29, 2022
@ml-evs ml-evs merged commit 05a0574 into master May 29, 2022
@ml-evs ml-evs deleted the ml-evs/add_client_import_guard branch May 29, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Issues/PRs relating to the OPTIMADE client. ergonomics Features that improve the usability of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant