Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable schema_url and index_schema_url options #1210

Merged
merged 6 commits into from Jun 11, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 31, 2022

Closes #1208

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1210 (6bd9f23) into master (a5691f7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6bd9f23 differs from pull request most recent head b4fd837. Consider uploading reports for the commit b4fd837 to get more accurate results

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
- Coverage   91.28%   91.27%   -0.01%     
==========================================
  Files          72       72              
  Lines        4289     4288       -1     
==========================================
- Hits         3915     3914       -1     
  Misses        374      374              
Flag Coverage Δ
project 91.27% <100.00%> (-0.01%) ⬇️
validator 90.67% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/exception_handlers.py 84.28% <ø> (ø)
optimade/server/routers/index_info.py 100.00% <ø> (ø)
optimade/server/routers/utils.py 98.13% <ø> (ø)
optimade/server/config.py 91.57% <100.00%> (+0.18%) ⬆️
optimade/server/routers/info.py 95.65% <100.00%> (+0.19%) ⬆️
optimade/server/entry_collections/elasticsearch.py 97.40% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5691f7...b4fd837. Read the comment docs.

optimade/server/config.py Outdated Show resolved Hide resolved
Co-authored-by: Johan Bergsma <JPBergsma@noreply.users.github.com>

Co-authored-by: Johan Bergsma <29785380+JPBergsma@users.noreply.github.com>
optimade/server/config.py Outdated Show resolved Hide resolved
@ml-evs ml-evs requested a review from JPBergsma June 9, 2022 18:27
@ml-evs ml-evs added server Issues pertaining to the example server implementation config For issues/PRs related to the server config. labels Jun 9, 2022
@ml-evs
Copy link
Member Author

ml-evs commented Jun 11, 2022

I think I have addressed your concern @JPBergsma, so I will merge

@ml-evs ml-evs merged commit 991591b into master Jun 11, 2022
@ml-evs ml-evs deleted the ml-evs/add_configurable_schema_url branch June 11, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config For issues/PRs related to the server config. server Issues pertaining to the example server implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configurable meta->schemas field to reference server
2 participants