Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for client when updating provider list #1222

Merged
merged 2 commits into from Jun 30, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jun 3, 2022

Timeouts/errors were previously not being caught when querying index meta-databases.

@ml-evs ml-evs added bug Something isn't working client Issues/PRs relating to the OPTIMADE client. labels Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #1222 (04cbe8f) into master (1a0fdc3) will decrease coverage by 0.05%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
- Coverage   91.29%   91.23%   -0.06%     
==========================================
  Files          72       72              
  Lines        4294     4299       +5     
==========================================
+ Hits         3920     3922       +2     
- Misses        374      377       +3     
Flag Coverage Δ
project 91.23% <28.57%> (-0.06%) ⬇️
validator 90.62% <28.57%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/utils.py 61.76% <28.57%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a0fdc3...04cbe8f. Read the comment docs.

@ml-evs ml-evs force-pushed the ml-evs/improve_client_error_handling branch from d29cabd to 7d35132 Compare June 9, 2022 13:09
@ml-evs
Copy link
Member Author

ml-evs commented Jun 9, 2022

Would you mind taking a look at this @JPBergsma?

@ml-evs ml-evs force-pushed the ml-evs/improve_client_error_handling branch from 7d35132 to 90692f2 Compare June 11, 2022 11:11
@ml-evs ml-evs added the priority/high Issue or PR with a consensus of high priority label Jun 11, 2022
JPBergsma
JPBergsma previously approved these changes Jun 30, 2022
Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response.
I have just been on holiday and there is a whole flood of messages from the last OPTIMADE meeting that I still have to get through.
The changes look good to me.

@ml-evs
Copy link
Member Author

ml-evs commented Jun 30, 2022

Sorry for the late response. I have just been on holiday and there is a whole flood of messages from the last OPTIMADE meeting that I still have to get through. The changes look good to me.

No problem @JPBergsma, hope you had a good holiday! I am very much still catching up too 😅 No need to rush through the other PRs.

@ml-evs ml-evs force-pushed the ml-evs/improve_client_error_handling branch from 90692f2 to cddc6c5 Compare June 30, 2022 14:34
@ml-evs ml-evs enabled auto-merge (squash) June 30, 2022 14:35
@ml-evs ml-evs disabled auto-merge June 30, 2022 16:39
@ml-evs ml-evs force-pushed the ml-evs/improve_client_error_handling branch from 45b716f to 04cbe8f Compare June 30, 2022 16:40
@ml-evs ml-evs merged commit 7dbc5b7 into master Jun 30, 2022
@ml-evs ml-evs deleted the ml-evs/improve_client_error_handling branch June 30, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issues/PRs relating to the OPTIMADE client. priority/high Issue or PR with a consensus of high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants