Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.10 instead of 3.7 in installation instructions #1229

Merged
merged 3 commits into from Jun 8, 2022

Conversation

JPBergsma
Copy link
Contributor

As we will soon drop support for python 3.7. It does not make sense to still use python 3.7 in the installation instructions.

As we will soon drop support for python 3.7. It does not make sense to still use python 3.7 in the installation instructions.
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1229 (40935e4) into master (064b2f7) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 40935e4 differs from pull request most recent head 85c2258. Consider uploading reports for the commit 85c2258 to get more accurate results

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
+ Coverage   91.27%   91.41%   +0.14%     
==========================================
  Files          72       72              
  Lines        4285     4285              
==========================================
+ Hits         3911     3917       +6     
+ Misses        374      368       -6     
Flag Coverage Δ
project 91.41% <ø> (+0.14%) ⬆️
validator 90.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/client/client.py 81.01% <0.00%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 064b2f7...85c2258. Read the comment docs.

@ml-evs ml-evs changed the title Use python 3.8 instead of 3.7 in installation instructions Use Python 3.8 instead of 3.7 in installation instructions Jun 8, 2022
@ml-evs ml-evs added the docs Issues pertaining to documentation. label Jun 8, 2022
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this @JPBergsma! In #1176 I use Python 3.10 as the new "main" CI version. Perhaps we should just jump straight to that?

INSTALL.md Outdated Show resolved Hide resolved
Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
@JPBergsma JPBergsma changed the title Use Python 3.8 instead of 3.7 in installation instructions Use Python 3.10 instead of 3.7 in installation instructions Jun 8, 2022
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ml-evs ml-evs enabled auto-merge (squash) June 8, 2022 17:41
@ml-evs ml-evs merged commit 32a2490 into master Jun 8, 2022
@ml-evs ml-evs deleted the JPBergsma-patch-1 branch June 8, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues pertaining to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants