Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lark dependency to new name #1231

Merged
merged 1 commit into from Jun 9, 2022
Merged

Update lark dependency to new name #1231

merged 1 commit into from Jun 9, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jun 8, 2022

Closes #1230.

@ml-evs ml-evs changed the title Update lark dependency to new name and versoin Update lark dependency to new name and version Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1231 (772346e) into master (32a2490) will not change coverage.
The diff coverage is n/a.

❗ Current head 772346e differs from pull request most recent head a3c7390. Consider uploading reports for the commit a3c7390 to get more accurate results

@@           Coverage Diff           @@
##           master    #1231   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files          72       72           
  Lines        4285     4285           
=======================================
  Hits         3911     3911           
  Misses        374      374           
Flag Coverage Δ
project 91.27% <ø> (ø)
validator 90.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a2490...a3c7390. Read the comment docs.

@ml-evs
Copy link
Member Author

ml-evs commented Jun 9, 2022

I am going to remove the lark update from this PR and merge just the package rename. We can then try to fix lark support to v1 through our normal dependabot system.

@ml-evs ml-evs changed the title Update lark dependency to new name and version Update lark dependency to new name Jun 9, 2022
@ml-evs ml-evs merged commit 1f02600 into master Jun 9, 2022
@ml-evs ml-evs deleted the ml-evs/bump_lark branch June 9, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump lark to v1
1 participant