Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change to fallback server.cfg #125

Merged
merged 2 commits into from Jan 9, 2020
Merged

Minor change to fallback server.cfg #125

merged 2 commits into from Jan 9, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 9, 2020

As outlined in a comment in (#119 (comment)), this PR modifies the construction of server.cfg if it's missing. Instead of using server_template.cfg, the created server.cfg uses the absolute paths of the default values for index_links and config.

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #125 into master will increase coverage by 0.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   82.73%   82.75%   +0.01%     
==========================================
  Files          39       39              
  Lines        1813     1815       +2     
==========================================
+ Hits         1500     1502       +2     
  Misses        313      313
Flag Coverage Δ
#unittests 82.75% <90%> (+0.01%) ⬆️
Impacted Files Coverage Δ
optimade/server/config.py 77.1% <90%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b833cf...bf5a379. Read the comment docs.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I found this error in my own server as well, but fixed it there.

This is better, although I don't see why we can't just delete server_template.cfg now?

@ml-evs
Copy link
Member Author

ml-evs commented Jan 9, 2020

Yeah, I found this error in my own server as well, but fixed it there.

This is better, although I don't see why we can't just delete server_template.cfg

Agreed and done.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quickfix @ml-evs !

@CasperWA CasperWA merged commit 5714922 into master Jan 9, 2020
@CasperWA CasperWA deleted the ml-evs/fixes branch January 9, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants