Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added homepage attribute to LinksResource #127

Merged
merged 6 commits into from Jan 10, 2020
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 9, 2020

See #115

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there's some trouble concerning getting the tests to run.

And I could swear i already did this, but maybe that was for something else? Oh well :)

Looking good 👍

optimade/server/data/test_links.json Outdated Show resolved Hide resolved
ml-evs and others added 2 commits January 10, 2020 00:06
Co-Authored-By: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
@CasperWA
Copy link
Member

CasperWA commented Jan 10, 2020

I'll look at this next week hopefully.

EDIT: Scratch that. Figured out the issue (see below).

@CasperWA CasperWA changed the title Added homepage attribute to LinksResource [BLOCKED] Added homepage attribute to LinksResource Jan 10, 2020
@CasperWA
Copy link
Member

This is blocked until Materials-Consortia/providers#7 has been merged, adding homepage to all providers.

@CasperWA CasperWA changed the title [BLOCKED] Added homepage attribute to LinksResource Added homepage attribute to LinksResource Jan 10, 2020
@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@e333304). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #127   +/-   ##
=========================================
  Coverage          ?   83.05%           
=========================================
  Files             ?       39           
  Lines             ?     1841           
  Branches          ?        0           
=========================================
  Hits              ?     1529           
  Misses            ?      312           
  Partials          ?        0
Flag Coverage Δ
#unittests 83.05% <100%> (?)
Impacted Files Coverage Δ
optimade/server/routers/utils.py 83.33% <ø> (ø)
optimade/server/main.py 92% <100%> (ø)
optimade/models/structures.py 88.28% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e333304...4ca961c. Read the comment docs.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine now - let's merge.

Thanks @ml-evs !

@CasperWA CasperWA merged commit c5b579f into master Jan 10, 2020
@CasperWA CasperWA deleted the ml-evs/links_homepage branch January 10, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants