Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent internal validator errors when entries are missing ID/type #1273

Merged
merged 1 commit into from Jul 16, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jul 16, 2022

Closes #1272.

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #1273 (6d3dbbd) into master (96543fe) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
- Coverage   91.23%   91.21%   -0.02%     
==========================================
  Files          72       72              
  Lines        4299     4301       +2     
==========================================
+ Hits         3922     3923       +1     
- Misses        377      378       +1     
Flag Coverage Δ
project 91.21% <66.66%> (-0.02%) ⬇️
validator 90.60% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/validator/validator.py 83.78% <66.66%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96543fe...6d3dbbd. Read the comment docs.

@ml-evs ml-evs marked this pull request as ready for review July 16, 2022 16:19
@ml-evs ml-evs merged commit 78163a7 into master Jul 16, 2022
@ml-evs ml-evs deleted the ml-evs/validator_tweaks branch July 16, 2022 16:19
@ml-evs ml-evs added bug Something isn't working validator Related to the OPTIMADE validator labels Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validator Related to the OPTIMADE validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal validator failures
1 participant