Remove incorrect default value for page_number query parameter
#1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some fun side effects here, will try to unpick soon. |
JPBergsma
reviewed
Aug 16, 2022
ml-evs
force-pushed
the
ml-evs/fix_default_page_number
branch
from
8063c09
to
c8726d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1303 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 72 72
Lines 4364 4364
=======================================
Hits 3967 3967
Misses 397 397
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ml-evs
force-pushed
the
ml-evs/fix_default_page_number
branch
from
c8726d8
to
798a102
Compare
ml-evs
force-pushed
the
ml-evs/fix_default_page_number
branch
from
798a102
to
bc005e2
Compare
|
This seems to work fine, and @JPBergsma already reviewed, so I will merge. |
ml-evs
changed the title
page_numberpage_number query parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As above. Reported by @blokhin in Materials-Consortia/schemas#8