Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reroute blank /structures/<id> query to /structures #132

Closed
wants to merge 3 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 13, 2020

Super minor. Closes #128.

@ml-evs ml-evs requested a review from CasperWA January 13, 2020 13:57
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #132 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   85.76%   85.77%           
=======================================
  Files          39       39           
  Lines        1834     1835    +1     
=======================================
+ Hits         1573     1574    +1     
  Misses        261      261           
Flag Coverage Δ
#unittests 85.77% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee3651...4b34784. Read the comment docs.

@ml-evs
Copy link
Member Author

ml-evs commented Jan 13, 2020

Hmmm, this generates a load of undesirable OpenAPI stuff atm, will investigate another way

@CasperWA
Copy link
Member

Maybe this can be helpful?

@CasperWA CasperWA changed the base branch from master to develop January 14, 2020 19:17
@CasperWA CasperWA changed the base branch from develop to master January 15, 2020 11:29
@ml-evs
Copy link
Member Author

ml-evs commented Feb 4, 2020

I'm going to close this as it doesn't seem to be an easy/wortwhile thing to do.

@ml-evs ml-evs closed this Feb 4, 2020
@CasperWA CasperWA deleted the alias_endpoints branch February 13, 2020 16:29
@CasperWA CasperWA restored the alias_endpoints branch February 13, 2020 16:33
@CasperWA CasperWA deleted the alias_endpoints branch February 13, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alias optimade/structures/ to optimade/structure
2 participants