Set correct meta->schema value automatically
#1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPBergsma
reviewed
Sep 6, 2022
JPBergsma
reviewed
Sep 6, 2022
ml-evs
force-pushed
the
ml-evs/simplify_schema_meta
branch
from
0e54d6a
to
cb96146
Compare
ml-evs
force-pushed
the
ml-evs/simplify_schema_meta
branch
from
cab3f7c
to
6655e0c
Compare
Done! |
Codecov Report
@@ Coverage Diff @@
## master #1323 +/- ##
==========================================
- Coverage 91.49% 91.46% -0.04%
==========================================
Files 72 72
Lines 4364 4368 +4
==========================================
+ Hits 3993 3995 +2
- Misses 371 373 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config option that tracks whether the reference server is in index or non-index mode, then uses that to correctly set the
meta->schemavalue in that server's responses.This means that a value no longer needs to be provided to the
meta_valuesfunction if not necessary (see aiidateam/aiida-optimade#375).Also tweaks the OpenAPI schema with a formatting change due to dependency updates.