Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin requirements in CD release workflows #1324

Merged
merged 2 commits into from Sep 6, 2022
Merged

Pin requirements in CD release workflows #1324

merged 2 commits into from Sep 6, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 5, 2022

It is possible for some tests to fail on CD but not CI; this PR pins the CD workflows to the same requirements file versions.

@ml-evs ml-evs changed the title Pin requirements in CI release workflows Pin requirements in CD release workflows Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@ec59112). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1324   +/-   ##
=========================================
  Coverage          ?   91.49%           
=========================================
  Files             ?       72           
  Lines             ?     4364           
  Branches          ?        0           
=========================================
  Hits              ?     3993           
  Misses            ?      371           
  Partials          ?        0           
Flag Coverage Δ
project 91.49% <ø> (?)
validator 90.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ml-evs,

I do not know much about GitHub actions, but as far as I can tell, everything looks ok to me.

@ml-evs
Copy link
Member Author

ml-evs commented Sep 6, 2022

Hi ml-evs,

I do not know much about GitHub actions, but as far as I can tell, everything looks ok to me.

This is unfortunately something that can only be tested properly by doing a release, I will try one later one and can babysit the workflow

@ml-evs ml-evs merged commit 99f47ee into master Sep 6, 2022
@ml-evs ml-evs deleted the ml-evs/update_ci branch September 6, 2022 08:56
@ml-evs ml-evs added the CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants