Remove randomness from structure utils tests #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
tests
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 72 72
Lines 4366 4366
=======================================
Hits 3993 3993
Misses 373 373
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously one of the structures tests were picking a random structure.
It looks like a recent test structure we added was causing this to fail like 1/20 times, so this PR removes the randomness by always testing all structures (takes milliseconds) and also always takes the absolute volume as a test value as the comparison method for computing volume is occasionally negative.