Do not enforce minimum value of page_number at model level
#1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/fix_page_number_schemas
branch
3 times, most recently
from
aa3f0b3
to
38d8b58
Compare
Codecov Report
@@ Coverage Diff @@
## master #1369 +/- ##
==========================================
+ Coverage 91.45% 91.59% +0.14%
==========================================
Files 72 72
Lines 4366 4369 +3
==========================================
+ Hits 3993 4002 +9
+ Misses 373 367 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ml-evs
force-pushed
the
ml-evs/fix_page_number_schemas
branch
3 times, most recently
from
fccf4e2
to
da90d4a
Compare
- This is to avoid spurious constraints being added to the OpenAPI schema - Validate page number dynamically for database queries - Add test for `page_number` validation
ml-evs
force-pushed
the
ml-evs/fix_page_number_schemas
branch
from
da90d4a
to
4ece278
Compare
ml-evs
force-pushed
the
ml-evs/fix_page_number_schemas
branch
from
4ece278
to
a210441
Compare
ml-evs
commented
Oct 26, 2022
ml-evs
commented
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see discussion at Materials-Consortia/schemas#8)
Closes #1372