Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH actions for deploying example server to Fly #1396

Merged
merged 3 commits into from Nov 21, 2022
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Nov 21, 2022

First PR addressing #1307 by deploying the app to Fly. Will also need a follow-up PR to remove all mentions of Heroku.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #1396 (7f63c15) into master (b21d894) will not change coverage.
The diff coverage is n/a.

❗ Current head 7f63c15 differs from pull request most recent head 5e93d39. Consider uploading reports for the commit 5e93d39 to get more accurate results

@@           Coverage Diff           @@
##           master    #1396   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files          72       72           
  Lines        4369     4369           
=======================================
  Hits         3996     3996           
  Misses        373      373           
Flag Coverage Δ
project 91.46% <ø> (ø)
validator 91.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ml-evs
Copy link
Member Author

ml-evs commented Nov 21, 2022

Seems to be working fine:

$ optimade-validator https://optimade.fly.dev
Testing entire implementation at https://optimade.fly.dev
.......✖.............................................................

OPTIONAL TEST FAILURES
======================

https://optimade.fly.dev/v123123 - _get_endpoint - failed with error
        ResponseError: Request to 'v123123' returned HTTP status code 404.
        Additional details from implementation:
          HTTPException: Not Found (N/A)


Passed 57 out of 57 tests.
Additionally passed 11 out of 12 optional tests.

This PR can't really be reviewed without testing, so I'll self-merge and then keep an eye on it.

@ml-evs ml-evs marked this pull request as ready for review November 21, 2022 18:03
@ml-evs ml-evs merged commit 4444272 into master Nov 21, 2022
@ml-evs ml-evs deleted the ml-evs/deploy_to_fly branch November 21, 2022 20:31
@ml-evs ml-evs added CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) deployment An app serves the OPTIMADE regular server labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) deployment An app serves the OPTIMADE regular server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant