New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorg models #14

Merged

dwinston merged 2 commits into master from reorg-models

Jun 12, 2019

Contributor

dwinston commented Jun 12, 2019 •

edited

Instead of one giant optimade.server.models module (file), optimade.server.models is now a subpackage (folder) with submodules:

jsonapi (classes implenting the JSON API spec)
util (low-level utilities used by other models)
baseinfo (for the base /info endpoint)
entries (for /entries, /entries/{id}, /entries/info)
structures (for structure entries, i.e. /structures/*)
toplevel (for top-level optimade responses. imports from other models modules)

It is fine to suggest adding submodules or moving classes to other (new) submodules.


          reorg models

f885c46

dwinston requested review from ltalirz, ml-evs and fawzi

June 12, 2019 10:41


          Update CI config to install reqs

42ea24d

Member

ml-evs commented Jun 12, 2019

lgtm, pending travis fix

ml-evs approved these changes

View reviewed changes

dwinston merged commit bcefa54 into master

ml-evs deleted the reorg-models branch

June 12, 2019 10:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment