Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo that breaks get_child_databases retriever #1411

Merged
merged 2 commits into from Dec 3, 2022
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 3, 2022

Closes #1410.

I will self-merge and release a hotfix.

@ml-evs ml-evs added bug Something isn't working client Issues/PRs relating to the OPTIMADE client. labels Dec 3, 2022
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #1411 (7561655) into master (105b501) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
+ Coverage   91.35%   91.39%   +0.04%     
==========================================
  Files          74       74              
  Lines        4374     4372       -2     
==========================================
  Hits         3996     3996              
+ Misses        378      376       -2     
Flag Coverage Δ
project 91.39% <0.00%> (+0.04%) ⬆️
validator 91.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/utils.py 60.00% <0.00%> (+1.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ml-evs ml-evs changed the title Fix typo that breaks child database retriever Fix typo that breaks get_child_databases retriever Dec 3, 2022
@ml-evs ml-evs merged commit f28bee2 into master Dec 3, 2022
@ml-evs ml-evs deleted the ml-evs/close_#1410 branch December 3, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issues/PRs relating to the OPTIMADE client.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot retrieve child database links
1 participant