New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure relevant package data is included in distributions #142
Conversation
Add test for how the distribution is built to make sure relevant package data is included.
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 85.74% 86.01% +0.26%
==========================================
Files 39 39
Lines 1824 1830 +6
==========================================
+ Hits 1564 1574 +10
+ Misses 260 256 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CasperWA for fixing the inclusion of the right files.
I still have a few reservations about the test you added but in the interest of time it's fine to proceed.
import unittest | ||
|
||
|
||
class TestSetup(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the real goal of this test is to "make sure that the PyPI distribution works".
I would argue that this is tested more strongly (and with less lines of code / maintenance needs) by adding a CI test that creates the package distribution, installs it (e.g. like this) and then runs either the whole test suite or some subset of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. We could definitely have a GH Actions workflow that does this.
Fixes #141
Bumps version to v0.3.2