Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure relevant package data is included in distributions #142

Merged
merged 4 commits into from Jan 20, 2020

Conversation

CasperWA
Copy link
Member

Fixes #141

Bumps version to v0.3.2

Add test for how the distribution is built to make sure relevant package
data is included.
@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #142 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   85.74%   86.01%   +0.26%     
==========================================
  Files          39       39              
  Lines        1824     1830       +6     
==========================================
+ Hits         1564     1574      +10     
+ Misses        260      256       -4
Flag Coverage Δ
#unittests 86.01% <100%> (+0.26%) ⬆️
Impacted Files Coverage Δ
optimade/server/mappers/entries.py 97.43% <ø> (ø) ⬆️
optimade/server/routers/utils.py 83.73% <100%> (+0.4%) ⬆️
optimade/server/config.py 93.26% <100%> (+0.26%) ⬆️
optimade/server/entry_collections.py 85.03% <100%> (+1.06%) ⬆️
optimade/server/routers/info.py 96.29% <100%> (+0.46%) ⬆️
optimade/server/exception_handlers.py 74.46% <0%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d661e6f...a51f30b. Read the comment docs.

MANIFEST.in Outdated Show resolved Hide resolved
@CasperWA CasperWA requested a review from ltalirz January 20, 2020 12:06
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CasperWA for fixing the inclusion of the right files.

I still have a few reservations about the test you added but in the interest of time it's fine to proceed.

import unittest


class TestSetup(unittest.TestCase):
Copy link
Member

@ltalirz ltalirz Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the real goal of this test is to "make sure that the PyPI distribution works".

I would argue that this is tested more strongly (and with less lines of code / maintenance needs) by adding a CI test that creates the package distribution, installs it (e.g. like this) and then runs either the whole test suite or some subset of it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. We could definitely have a GH Actions workflow that does this.

@CasperWA CasperWA merged commit be7816b into master Jan 20, 2020
@CasperWA CasperWA deleted the fix_141_package_lark_files branch January 20, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lark files not being distributed
2 participants