Allow empty strings through chemical formula regexp #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
schema
ml-evs
force-pushed
the
ml-evs/relax_chemform_regexp
branch
from
729e6e5
to
1c466f4
Compare
ml-evs
force-pushed
the
ml-evs/relax_chemform_regexp
branch
from
1c466f4
to
4c18c23
Compare
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 74 74
Lines 4392 4392
=======================================
Hits 4016 4016
Misses 376 376
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last PR of the day, and one that can actually be reviewed and merged.
After discussions in Materials-Consortia/OPTIMADE#388, it seems that empty formulae should be allowed -- though we should wait until it is really resolved to merge this.
This PR adjusted the regexp for this and moves the test case around.
This has knock-on effects on open PRs in other repos (schemas, specification) that will need to be untangled at a later date.