Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache /info and /info/<entry> responses #1433

Merged
merged 1 commit into from Dec 15, 2022
Merged

Cache /info and /info/<entry> responses #1433

merged 1 commit into from Dec 15, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 14, 2022

This is a feature I want to use in the 1.2 changes, so it may as well be "backported" here ready for the final 1.1 release.

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1433 (1060331) into master (eae4846) will increase coverage by 0.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
+ Coverage   91.43%   91.45%   +0.01%     
==========================================
  Files          74       74              
  Lines        4392     4398       +6     
==========================================
+ Hits         4016     4022       +6     
  Misses        376      376              
Flag Coverage Δ
project 91.45% <94.44%> (+0.01%) ⬆️
validator 90.85% <94.44%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/routers/info.py 96.55% <94.44%> (+0.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ml-evs ml-evs added the server Issues pertaining to the example server implementation label Dec 14, 2022
Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me.

@ml-evs ml-evs merged commit 5478fb8 into master Dec 15, 2022
@ml-evs ml-evs deleted the ml-evs/info_cache branch December 15, 2022 11:06
@ml-evs ml-evs added the enhancement New feature or request label Dec 21, 2022
@ml-evs ml-evs mentioned this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server Issues pertaining to the example server implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants