Add compatibility for httpx-based TestClient for latest FastAPI version
#1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
validator
Codecov Report
@@ Coverage Diff @@
## master #1460 +/- ##
==========================================
- Coverage 91.45% 91.43% -0.03%
==========================================
Files 74 74
Lines 4399 4411 +12
==========================================
+ Hits 4023 4033 +10
- Misses 376 378 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Bumps [fastapi](https://github.com/tiangolo/fastapi) from 0.86.0 to 0.88.0. - [Release notes](https://github.com/tiangolo/fastapi/releases) - [Commits](tiangolo/fastapi@0.86.0...0.88.0) --- updated-dependencies: - dependency-name: fastapi dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
ml-evs
force-pushed
the
ml-evs/update_testclient
branch
from
39f6291
to
c244123
Compare
JPBergsma
reviewed
Jan 5, 2023
|
Thanks for the review @JPBergsma! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates tests, validator and client usage of requests/httpx to add compatibility for the new
httpx-basedTestClientrequired by the latest FastAPI version (whilst also maintaining compatibility with older versions).To do this, I had to:
pytest-httpxas it caused infinite recursion between the mocked test client and the mocked requests themselves, with no clean workaroundhttpx.URLnow used within the test clientOptimadeClient, so a patched test client can be specified directlyhttpxandrequestsWe can probably now begin the process of using httpx in the validator too, though a naive switch out lead to some errors that I don't want to fix in this PR.