Add ability to save client results directly from Python #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/save_client_results
branch
from
c480c32
to
e03b199
Compare
ml-evs
force-pushed
the
ml-evs/save_client_results
branch
from
e03b199
to
4dfac86
Compare
|
Superseded by #1519, IMO. If someone wants to save all data at once after the query, they can just json dump the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
save_asargument toget()which will save the results of a single query to a JSON file.It also adds the
.save()method which will save all results from the current client, making efforts to aggregate any existing results in that file.This could begin the preliminary work for persistent local caching of OPTIMADE results. Caveats: what to do if not all responses fields are requested the first time around --- probably need to hash the precise query URLs and use those in the cache.