Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split eager and standard tests to avoid unnecessary badge of shame #148

Merged
merged 2 commits into from Jan 24, 2020
Merged

Split eager and standard tests to avoid unnecessary badge of shame #148

merged 2 commits into from Jan 24, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 24, 2020

As above.

@ml-evs ml-evs requested a review from CasperWA January 24, 2020 11:14
@codecov
Copy link

codecov bot commented Jan 24, 2020 •
edited

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files          39       39           
  Lines        1830     1830           
=======================================
  Hits         1570     1570           
  Misses        260      260
Flag Coverage Δ
#unittests 85.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51df1b3...4b9412d. Read the comment docs.

@ml-evs ml-evs mentioned this pull request Jan 24, 2020
Merged
CasperWA
CasperWA approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea this. Thanks @ml-evs

@CasperWA CasperWA merged commit a16b352 into master Jan 24, 2020
@CasperWA CasperWA deleted the ml-evs/ci branch January 24, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ml-evs @CasperWA