Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated lark-parser to 0.8.1 #149

Merged
merged 4 commits into from Jan 24, 2020
Merged

Updated lark-parser to 0.8.1 #149

merged 4 commits into from Jan 24, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 24, 2020

Only a tiny fix was required, due to changes to the VisitError format. Made very easy to spot thanks to our meticulous tests on the exceptions raised in the grammar!

Closes #146

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #149 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #149      +/-   ##
=========================================
+ Coverage   85.79%   85.8%   +<.01%     
=========================================
  Files          39      39              
  Lines        1830    1831       +1     
=========================================
+ Hits         1570    1571       +1     
  Misses        260     260
Flag Coverage Δ
#unittests 85.8% <100%> (ø) ⬆️
Impacted Files Coverage Δ
optimade/server/exception_handlers.py 75% <100%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91bfb97...4ac311d. Read the comment docs.

@CasperWA
Copy link
Member

Maybe we should fix this upstream as well - or simply open an issue?

@Materials-Consortia Materials-Consortia deleted a comment from ml-evs Jan 24, 2020
CasperWA
CasperWA previously approved these changes Jan 24, 2020
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this quick-fix @ml-evs!

optimade/server/exception_handlers.py Outdated Show resolved Hide resolved
@CasperWA CasperWA merged commit 252dd34 into master Jan 24, 2020
@CasperWA CasperWA deleted the ml-evs/lark_updates branch January 24, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail with lark-parser>=0.8
2 participants