Increase client timeouts and tweak response_fields behaviour
#1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPBergsma
reviewed
Feb 14, 2023
Co-authored-by: Johan Bergsma <29785380+JPBergsma@users.noreply.github.com>
ml-evs
force-pushed
the
ml-evs/client_tweaks
branch
from
74ed0e5
to
af75a04
Compare
Codecov Report
@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
- Coverage 91.01% 91.01% -0.01%
==========================================
Files 74 74
Lines 4475 4484 +9
==========================================
+ Hits 4073 4081 +8
- Misses 402 403 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ml-evs
force-pushed
the
ml-evs/client_tweaks
branch
from
af75a04
to
5121fcf
Compare
ml-evs
added
enhancement
ml-evs
changed the title
response_fields behaviourresponse_fields behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the default HTTP read timeout and makes it configurable via a parameter.
Also reduces the response fields to just "id" when a count query is being performed.