Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some validator error messages #1557

Merged
merged 2 commits into from Mar 13, 2023
Merged

Improve some validator error messages #1557

merged 2 commits into from Mar 13, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 13, 2023

This PR makes a couple of minor tweaks to the validator.

  • Prevent internal failures when checking meta->schema of a request that has already failed
  • Improve a couple of error messages

@ml-evs ml-evs added the validator Related to the OPTIMADE validator label Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1557 (e8cbd05) into master (20b1e87) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1557   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files          74       74           
  Lines        4538     4538           
=======================================
  Hits         4133     4133           
  Misses        405      405           
Flag Coverage Δ
project 91.07% <100.00%> (ø)
validator 90.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/validator/validator.py 83.51% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ml-evs ml-evs merged commit 0060f44 into master Mar 13, 2023
@ml-evs ml-evs deleted the ml-evs/fix_validator branch March 13, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validator Related to the OPTIMADE validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant