Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious errors when running validator with --skip-optional #1559

Merged
merged 2 commits into from Mar 14, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 14, 2023

Closes #1558

@ml-evs ml-evs added the validator Related to the OPTIMADE validator label Mar 14, 2023
@ml-evs ml-evs force-pushed the ml-evs/fix_validator branch 2 times, most recently from 19f9025 to 10c317c Compare March 14, 2023 13:56
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@0060f44). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1559   +/-   ##
=========================================
  Coverage          ?   91.09%           
=========================================
  Files             ?       74           
  Lines             ?     4538           
  Branches          ?        0           
=========================================
  Hits              ?     4134           
  Misses            ?      404           
  Partials          ?        0           
Flag Coverage Δ
project 91.09% <100.00%> (?)
validator 90.98% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/validator/utils.py 94.59% <100.00%> (ø)
optimade/validator/validator.py 83.69% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Co-authored-by: Johan Bergsma <29785380+JPBergsma@users.noreply.github.com>
@ml-evs
Copy link
Member Author

ml-evs commented Mar 14, 2023

Thanks @JPBergsma, well caught! I'll merge this now.

@ml-evs ml-evs merged commit d779725 into master Mar 14, 2023
@ml-evs ml-evs deleted the ml-evs/fix_validator branch March 14, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validator Related to the OPTIMADE validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator presents internal errors when run with --skip-optional
2 participants