Extract next link query param creation into EntriesCollection method. #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markus1978
force-pushed
the
ms/customizable_next_params
branch
3 times, most recently
from
c5b1a98
to
47e808c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1561 +/- ##
=======================================
Coverage 91.09% 91.10%
=======================================
Files 74 74
Lines 4538 4542 +4
=======================================
+ Hits 4134 4138 +4
Misses 404 404
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
markus1978
force-pushed
the
ms/customizable_next_params
branch
from
47e808c
to
d495b24
Compare
ml-evs
force-pushed
the
ms/customizable_next_params
branch
from
d495b24
to
9e58e9f
Compare
ml-evs
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow different
EntriesCollectionimplementations to alter how the URL query parameters for the next links are produced. How request params are handled is already part ofEntriesCollection, it would be logical to also have the request params for the "next" request handled here.The value-based pagination can depend on back-end implementation details. For example, in elasticsearch you would combine the sort-by property values with ids to create a value with tie-breaker.