Small code corrections #1562
Merged
Small code corrections #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # openapi/openapi.json # optimade/models/__init__.py # optimade/models/jsonapi.py # optimade/models/structures.py # optimade/server/mappers/__init__.py # optimade/server/middleware.py # optimade/server/routers/info.py # optimade/server/routers/utils.py # optimade/server/schemas.py # optimade/server/warnings.py # optimade/validator/config.py # requirements.txt # setup.py # tests/server/conftest.py # tests/server/test_mappers.py
-query_parameters flag and removed config_file field from default config example.
…om default config example.
…/JPBergsma/optimade-python-tools into JPBergsma/small_code_corrections
# Conflicts: # openapi/openapi.json # optimade/server/entry_collections/entry_collections.py # optimade/server/routers/utils.py # providers # requirements.txt
JPBergsma
force-pushed
the
JPBergsma/small_code_corrections
branch
from
7e359be
to
250d0fd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1562 +/- ##
==========================================
+ Coverage 91.09% 91.12% +0.02%
==========================================
Files 74 74
Lines 4538 4541 +3
==========================================
+ Hits 4134 4138 +4
+ Misses 404 403 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ml-evs
previously approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Thanks @JPBergsma, couple of minor comments but I'll approve and you can do as you wish
openapi/openapi.json
Outdated
| @@ -3645,8 +3645,8 @@ | |||
| "description": "Cartesian positions of each site in the structure.\nA site is usually used to describe positions of atoms; what atoms can be encountered at a given site is conveyed by the `species_at_sites` property, and the species themselves are described in the `species` property.\n\n- **Type**: list of list of floats\n\n- **Requirements/Conventions**:\n - **Support**: SHOULD be supported by all implementations, i.e., SHOULD NOT be `null`.\n - **Query**: Support for queries on this property is OPTIONAL.\n If supported, filters MAY support only a subset of comparison operators.\n - It MUST be a list of length equal to the number of sites in the structure, where every element is a list of the three Cartesian coordinates of a site expressed as float values in the unit angstrom (\u00c5).\n - An entry MAY have multiple sites at the same Cartesian position (for a relevant use of this, see e.g., the property `assemblies`).\n\n- **Examples**:\n - `[[0,0,0],[0,0,2]]` indicates a structure with two sites, one sitting at the origin and one along the (positive) *z*-axis, 2 \u00c5 away from the origin.", | |||
| "nullable": true, | |||
| "x-optimade-queryable": "optional", | |||
| "x-optimade-support": "should", | |||
| "x-optimade-unit": "\u00c5" | |||
| "x-optimade-unit": "\u00c5", | |||
There was a problem hiding this comment.
I'm really confused about what order this thing keeps changing it to (see #1429)... all the other changes are fine as they are alphabetical but this one seems to be the opposite.
There was a problem hiding this comment.
Okay I think the issue is actually with the release workflow, which keeps changing it back: 01101a4
Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several small changes I came across over the past months.
The most important one is to increase the sleep time for the elastic search container, as it takes more than 10 seconds to start on my laptop.