Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix provider homepage on landing page #1569

Merged
merged 1 commit into from Mar 20, 2023
Merged

Fix provider homepage on landing page #1569

merged 1 commit into from Mar 20, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 20, 2023 •
edited

Closes #1568

@JPBergsma
Copy link
Contributor

I just had a look, and it seems it was already present in version 0.19.4

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@d894c7a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1569   +/-   ##
=========================================
  Coverage          ?   91.04%           
=========================================
  Files             ?       74           
  Lines             ?     4578           
  Branches          ?        0           
=========================================
  Hits              ?     4168           
  Misses            ?      410           
  Partials          ?        0
Flag Coverage Δ
project 91.04% <ø> (?)
validator 90.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

JPBergsma
JPBergsma approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix it for me.

@ml-evs ml-evs marked this pull request as ready for review March 20, 2023 11:58
@ml-evs ml-evs requested a review from CasperWA as a code owner March 20, 2023 11:58
@ml-evs ml-evs merged commit 61386dd into master Mar 20, 2023
12 checks passed
@ml-evs ml-evs deleted the ml-evs-patch-1 branch March 20, 2023 11:58
JPBergsma pushed a commit to JPBergsma/optimade-python-tools that referenced this pull request Mar 20, 2023
@ml-evs @JPBergsma
Fix provider homepage on landing page (Materials-Consortia#1569)
5e23598
JPBergsma pushed a commit to JPBergsma/optimade-python-tools that referenced this pull request Apr 3, 2023
@ml-evs @JPBergsma
Fix provider homepage on landing page (Materials-Consortia#1569)
3c4a09b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPBergsma JPBergsma JPBergsma approved these changes

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Landing page provider homepage link is broken
2 participants
@ml-evs @JPBergsma