Links can be strings #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltalirz
previously approved these changes
Jun 12, 2019
There was a problem hiding this comment.
@fawzi I think this is fine in terms of translating what optimade wants.
It is not part of the json api specification (see e.g. Materials-Consortia/API#18), so we should probably keep it outside the jsonapi.py file.
@tpurcell90 is currently working on adding the full json api spec in there, so I think he'll be fine with taking care of moving this class out of jsonapi.py (and creating a Link somewhere else that inherits from the JSON API link and adds the base_url).
dwinston
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.