Reorder tests #162
Merged
Reorder tests #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further reorder tests, making the base test class `EndpointTestsMixin` the base for all endpoint tests, no matter the server being tested. `TestClient`s are now retrieved through utility functions.
ml-evs
approved these changes
Feb 5, 2020
This was referenced Feb 5, 2020
Merged
CasperWA
added a commit
that referenced
this pull request
Feb 6, 2020
Bump to v0.4.0 Changes: Changes: - Reorder test files and update testing endpoints setup (#162, @CasperWA) - Separate the regular and index-meta database server, making sure they're not importing each other (#160, @CasperWA) - Introduce Starlette/FastAPI HTTP middleware for redirecting URLs ending with a slash to URLs _not_ ending with a slash (#160, @CasperWA) - Fix validation of `dimension_types` resulting in `response_fields` failing and add tests for `response_fields` (#153, @CasperWA) - Update entry list property descriptions according to updated OPTiMaDe spec (#153, @CasperWA) - Validate updated entry list properties and test updated entry list properties (#153, @ml-evs) - Add OpenAPI schema descriptions for query parameters (#166, @CasperWA) - Remove custom constrained types `NonnegativeInt` and `conlist` and use instead standard types together with `pydantic`'s `FieldInfo` parameters for schema generation and validation (#166, @shyamd, @CasperWA)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding more tests for PR #153 I found it a bit messy, so I started reordering the tests - this is the result.
I would like to suggest we change the server file
deps.pytoquery_params.pyas well, since it's a more descriptive name. It would also reflect the reordering in this PR as well.