Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client callbacks to dynamically set the next URL #1685

Merged
merged 4 commits into from Jul 22, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jun 29, 2023

This is useful for dynamic querying, e.g., changing a filter based on the number of results, or skipping forward to later pages.

@ml-evs ml-evs added the client Issues/PRs relating to the OPTIMADE client. label Jun 29, 2023
@ml-evs ml-evs force-pushed the ml-evs/restartable-client branch 2 times, most recently from dc71695 to c87c7ef Compare June 29, 2023 11:20
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #1685 (ff663f9) into master (a8e28e1) will decrease coverage by 0.06%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #1685      +/-   ##
==========================================
- Coverage   90.92%   90.87%   -0.06%     
==========================================
  Files          74       74              
  Lines        4608     4612       +4     
==========================================
+ Hits         4190     4191       +1     
- Misses        418      421       +3     
Flag Coverage Δ
project 90.87% <94.11%> (-0.06%) ⬇️
validator 90.76% <94.11%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/client/client.py 81.92% <88.88%> (+0.16%) ⬆️
...made/server/entry_collections/entry_collections.py 95.83% <100.00%> (-0.05%) ⬇️
optimade/server/routers/links.py 100.00% <100.00%> (ø)
optimade/server/routers/references.py 100.00% <100.00%> (ø)
optimade/server/routers/structures.py 100.00% <100.00%> (ø)
optimade/server/routers/utils.py 95.12% <100.00%> (-0.82%) ⬇️

... and 1 file with indirect coverage changes

@ml-evs ml-evs force-pushed the ml-evs/restartable-client branch 3 times, most recently from 8966d2b to 70328ef Compare July 5, 2023 19:13
@ml-evs ml-evs force-pushed the ml-evs/restartable-client branch from 70328ef to ff663f9 Compare July 22, 2023 09:58
@ml-evs ml-evs merged commit d41929a into master Jul 22, 2023
11 checks passed
@ml-evs ml-evs deleted the ml-evs/restartable-client branch July 22, 2023 11:15
@ml-evs ml-evs changed the title Allow client callbacks to overwrite the next URL Allow client callbacks to dynamically set the next URL Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Issues/PRs relating to the OPTIMADE client.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant