Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed elements_ratios length alias bug #1713

Merged
merged 3 commits into from Jul 19, 2023
Merged

Fixed elements_ratios length alias bug #1713

merged 3 commits into from Jul 19, 2023

Conversation

JPBergsma
Copy link
Contributor

The name for the variable holding the fractions of each element in the structure is "elements_ratios" yet here it was spelled as "element_ratios".

The name for the variable holding the fractions of each element in the structure is "elements_ratios" yet here it was spelled as "element_ratios".
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1713 (ea1b723) into master (57d3855) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1713   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files          74       74           
  Lines        4608     4608           
=======================================
  Hits         4190     4190           
  Misses        418      418           
Flag Coverage Δ
project 90.92% <ø> (ø)
validator 90.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/mappers/structures.py 100.00% <ø> (ø)

@JPBergsma JPBergsma merged commit 6a30267 into master Jul 19, 2023
11 checks passed
@JPBergsma JPBergsma deleted the JPBergsma-patch-1 branch July 19, 2023 16:47
@ml-evs ml-evs added the bug Something isn't working label Jul 22, 2023
@ml-evs ml-evs changed the title Fixed bug in LENGTH_ALIASES StructureMapper Fixed elements_ratios length alias bug Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants