Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not raise local OPTIMADE warnings at server level #1718

Merged
merged 1 commit into from Jul 22, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jul 22, 2023

This PR removes the annoying feature that MissingExpectedField warnings pollute the server logs when a partial model is constructed.

@ml-evs ml-evs added server Issues pertaining to the example server implementation ergonomics Features that improve the usability of the package labels Jul 22, 2023
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #1718 (c30e11d) into master (b377447) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1718   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files          74       74           
  Lines        4612     4615    +3     
=======================================
+ Hits         4191     4194    +3     
  Misses        421      421           
Flag Coverage Δ
project 90.87% <100.00%> (+<0.01%) ⬆️
validator 90.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/middleware.py 95.39% <100.00%> (+0.06%) ⬆️
optimade/warnings.py 90.47% <100.00%> (+0.47%) ⬆️

@ml-evs ml-evs force-pushed the ml-evs/local_optimade_warnings branch from 37cc332 to c30e11d Compare July 22, 2023 11:22
@ml-evs ml-evs merged commit d96e3a8 into master Jul 22, 2023
11 checks passed
@ml-evs ml-evs deleted the ml-evs/local_optimade_warnings branch July 22, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ergonomics Features that improve the usability of the package server Issues pertaining to the example server implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant