Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate fully to pyproject.toml #1737

Merged
merged 7 commits into from Aug 10, 2023
Merged

Migrate fully to pyproject.toml #1737

merged 7 commits into from Aug 10, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Aug 2, 2023

This PR replaces setup.py and MANIFEST.in with a modern pyproject.toml file, as well as making many assorted tweaks to our CI and tests.

@ml-evs ml-evs force-pushed the ml-evs/pyproject branch 3 times, most recently from e1ff868 to c781b87 Compare August 2, 2023 22:35
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1737 (f885928) into master (181dcd2) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1737      +/-   ##
==========================================
- Coverage   90.87%   90.85%   -0.03%     
==========================================
  Files          74       74              
  Lines        4615     4615              
==========================================
- Hits         4194     4193       -1     
- Misses        421      422       +1     
Flag Coverage Δ
project 90.85% <ø> (-0.03%) ⬇️
validator 90.74% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
optimade/validator/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@ml-evs ml-evs force-pushed the ml-evs/pyproject branch 5 times, most recently from 8d3ccee to ead1584 Compare August 9, 2023 11:59
@ml-evs ml-evs marked this pull request as ready for review August 9, 2023 12:08
@ml-evs ml-evs changed the title Attempt to migrate fully to pyproject.toml Migrate fully to pyproject.toml Aug 9, 2023
Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see anything strange in this PR, although it is also not really my expertise.
The added comma in test_utils.py seems unnecessary, but is not important enough to block this PR.

@ml-evs
Copy link
Member Author

ml-evs commented Aug 10, 2023

The added comma in test_utils.py seems unnecessary, but is not important enough to block this PR.

Indeed, tell that to black! Thanks anyway

@ml-evs ml-evs merged commit 028bee1 into master Aug 10, 2023
11 checks passed
@ml-evs ml-evs deleted the ml-evs/pyproject branch August 10, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants