Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors parsing IDs that contain slashes #183

Merged
merged 6 commits into from
Mar 4, 2020
Merged

Fix errors parsing IDs that contain slashes #183

merged 6 commits into from
Mar 4, 2020

Commits on Mar 4, 2020

  1. Added test cases that should pass

    @ml-evs @CasperWA
    ml-evs authored and CasperWA committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    3c48d18 View commit details
    Browse the repository at this point in the history

  2. Special grammar rule(s) for id property 

    Since id values may be given without being an escaped string (i.e.,
without quotation marks `"`) this needs to be taken into account in the
grammar.

Up to this point, the only allowed values for id (without quotation
marks) were as a "property", i.e., r"\._[a-z][0-9]", so no capital
letters, nor any special characters, e.g., like `/`.
    @CasperWA
    CasperWA committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    d2eede3 View commit details
    Browse the repository at this point in the history

  3. Add tests for MongoTransformer

    @CasperWA
    CasperWA committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    2a22470 View commit details
    Browse the repository at this point in the history

  4. Enclose ID in double quotes when filtering for included data

    @ml-evs @CasperWA
    ml-evs authored and CasperWA committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    b854cdd View commit details
    Browse the repository at this point in the history

  5. Remove grammar rules added for IDs. 

    This commit effectively reverts 1546bd.

Co-Authored-By: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
    @ml-evs @CasperWA
    ml-evs and CasperWA committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    e80daf5 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into ml-evs/parser_issues

    @ml-evs
    ml-evs committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    5ff98d5 View commit details
    Browse the repository at this point in the history