Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional test for whether entry endpoints have any actual entries #1891

Merged
merged 1 commit into from Dec 4, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 4, 2023

Closes #1890

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eaa4315) 90.86% compared to head (68e5973) 90.81%.

Files Patch % Lines
optimade/validator/validator.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
- Coverage   90.86%   90.81%   -0.05%     
==========================================
  Files          75       75              
  Lines        4652     4661       +9     
==========================================
+ Hits         4227     4233       +6     
- Misses        425      428       +3     
Flag Coverage Δ
project 90.81% <66.66%> (-0.05%) ⬇️
validator 90.68% <66.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs merged commit c34410c into master Dec 4, 2023
11 of 12 checks passed
@ml-evs ml-evs deleted the ml-evs/validator-error-on-empty branch December 4, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator does not error on empty endpoints
1 participant