Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper pin to numpy in preparation for v2 #1928

Merged
merged 1 commit into from Jan 11, 2024
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 11, 2024

In preparation for https://numpy.org/devdocs/numpy_2_0_migration_guide.html.

We barely use numpy ourselves but some of our optional deps definitely do, so this will probably end up blocking until the whole cascade of deps updates has finished. Also should be backported to the v0.25.x branch and releases.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f17897f) 90.77% compared to head (aead9d7) 90.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1928   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          75       75           
  Lines        4728     4728           
=======================================
  Hits         4292     4292           
  Misses        436      436           
Flag Coverage Δ
project 90.77% <ø> (ø)
validator 90.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs marked this pull request as ready for review January 11, 2024 12:47
@ml-evs ml-evs merged commit c3ed532 into master Jan 11, 2024
12 checks passed
@ml-evs ml-evs deleted the ml-evs/pin-numpy branch January 11, 2024 12:47
@ml-evs ml-evs restored the ml-evs/pin-numpy branch January 11, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant