Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper pin for pandas and ignore pandas3/pyarrow deprecation warning #1945

Merged
merged 1 commit into from Jan 22, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 22, 2024

This PR ignores a new deprecation warning for pandas (sub-dep of pymatgen) and adds an upper pin for the case the message reflects (missing pyarrow). pandas v3 will therefore break pymatgen first so we shouldn't have to worry too much here.

Annoying gotcha: the emitted deprecation warning starts with a newline (took a while to notice this...) and filterwarnings only matches from the start of strings, so various obvious regex attempts fail and the newline needs to be explicitly added to the filter.

@ml-evs ml-evs force-pushed the ml-evs/pandas3-warning branch 3 times, most recently from 24c296b to 450ae86 Compare January 22, 2024 10:55
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b646a0a) 90.75% compared to head (35a30d2) 90.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1945   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files          75       75           
  Lines        4729     4729           
=======================================
  Hits         4292     4292           
  Misses        437      437           
Flag Coverage Δ
project 90.75% <ø> (ø)
validator 90.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs merged commit 0013b2a into master Jan 22, 2024
12 checks passed
@ml-evs ml-evs deleted the ml-evs/pandas3-warning branch January 22, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant