Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JSON diff test #20

Merged
merged 6 commits into from Jun 13, 2019
Merged

Added JSON diff test #20

merged 6 commits into from Jun 13, 2019

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jun 13, 2019

To enforce consistency between Python generated and committed OpenAPI JSON, if the json diff is not null (i.e. "{}"), the CI will fail.

@ml-evs ml-evs requested a review from ltalirz June 13, 2019 08:20
ltalirz
ltalirz previously approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go!

@ltalirz ltalirz self-requested a review June 13, 2019 09:19
ltalirz
ltalirz approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ltalirz ltalirz merged commit bea16c7 into master Jun 13, 2019
@ltalirz ltalirz mentioned this pull request Jun 13, 2019
Closed
3 tasks
@CasperWA CasperWA deleted the travis-json-updates branch November 8, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltalirz ltalirz ltalirz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ml-evs @ltalirz @dwinston