Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update handling of include parameter (and other query parameters) #209

Merged
merged 5 commits into from
Mar 5, 2020
Merged

Update handling of include parameter (and other query parameters) #209

merged 5 commits into from
Mar 5, 2020

Commits on Mar 5, 2020

  1. Correct handling of include values, updating tests 

    This is according to the discussion in issue
Materials-Consortia/OPTIMADE#259
    @CasperWA
    CasperWA committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    a94c564 View commit details
    Browse the repository at this point in the history

  2. New middleware to check integrity of query params

    @CasperWA
    CasperWA committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    8fdb8bb View commit details
    Browse the repository at this point in the history

  3. Add BadRequest to new exceptions.py 

    Add new middleware to index meta-db server.
Update single-entry endpoints handling of include parameter.

Add tests for new middleware.
    @CasperWA
    CasperWA committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    735271f View commit details
    Browse the repository at this point in the history

  4. Move _check_error_response() to parent class 

    Unfortunately, this cannot also be done for _check_response(), since
this differs quite significantly in what it tests from test class to
test class.
    @CasperWA
    CasperWA committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    528d0bf View commit details
    Browse the repository at this point in the history

  5. Correct query string for middleware test 

    Co-Authored-By: Matthew Evans <me388@cam.ac.uk>
    @CasperWA @ml-evs
    CasperWA and ml-evs committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    e5a8bc1 View commit details
    Browse the repository at this point in the history