Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mentions of action in readme #231

Merged
merged 2 commits into from Mar 16, 2020
Merged

Update mentions of action in readme #231

merged 2 commits into from Mar 16, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 16, 2020

Closes #230.

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #231 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   87.57%   87.57%           
=======================================
  Files          43       43           
  Lines        1916     1916           
=======================================
  Hits         1678     1678           
  Misses        238      238           
Flag Coverage Δ
#unittests 87.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdbdf9...1f208ea. Read the comment docs.

CasperWA
CasperWA previously approved these changes Mar 16, 2020
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A small comment to reiterate the sentence above.

README.md Outdated
## Links

- [OPTiMaDe Specification](https://github.com/Materials-Consortia/OPTiMaDe/blob/develop/optimade.rst), the human-readable specification that this library is based on.
- [optimade-validator-action](https://github.com/Materials-Consortia/optimade-validator-action), a GitHub action that can be used to validate implementations from a URL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [optimade-validator-action](https://github.com/Materials-Consortia/optimade-validator-action), a GitHub action that can be used to validate implementations from a URL.
- [optimade-validator-action](https://github.com/Materials-Consortia/optimade-validator-action), a GitHub action that can be used to validate implementations from a URL (using the validator from this repo).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or something similar?

Co-Authored-By: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
@CasperWA CasperWA merged commit 855f310 into master Mar 16, 2020
@CasperWA CasperWA deleted the ml-evs/readme_update branch March 16, 2020 14:36
@CasperWA CasperWA mentioned this pull request Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove validator action from README
2 participants