Json api add #24
Merged
Json api add #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the JSON API to the spec generator, need to figure out how to add patternProperties
Removed a set function since I can't find how to add patternProperties, and some are recasting of other types
Relationships are now added to the jsonapi file, but does not work in our tests. If you print the pydantic schema it works as I would expect, but it is not working in openapi.json
JSON API should now agree, outside of the bug where print CLASS.schema() and openapi.json disagree
|
@tpurcell90 The only check that fails is the one checking that the schema generated by the server equals the one committed in |
Adding the openapi.json onto the remote branch. Before merge I'll compare with the one on master
ltalirz
reviewed
Jun 13, 2019
|
|
||
| class Link(BaseModel): | ||
| href: UrlStr | ||
| meta: Optional[dict] | ||
|
|
||
|
|
||
| class Links(BaseModel): | ||
| next: Optional[Union[UrlStr,Link]] | ||
| base_url: Optional[Union[UrlStr,Link]] |
There was a problem hiding this comment.
would you agree that this should be moved into an "optimade" links class?
I guess base_url is not part of the jsonapi links spec?
There was a problem hiding this comment.
Yes I'd move that into an "optimade". The json representation of Links is more general
"links": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/link"
}
},
ltalirz
requested changes
Jun 13, 2019
ltalirz
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12
Adds the JSON API to solve #12.
Because of issues with pydantic #22 and #23 persist. If pydantic is updated to support these then the jsonapi file can be updated