Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Local Tests #240

Merged
merged 2 commits into from Mar 25, 2020
Merged

Fixes Local Tests #240

merged 2 commits into from Mar 25, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Mar 25, 2020

This fixes #239 by making pytest set the environment variable for OPTIMADE_CONFIG_PATH before it collects any tests. This is needed since many of the objects in the server are module-level singletons that get configured on import. In the future, we should fix that.

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #240 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files          43       43           
  Lines        1862     1862           
=======================================
  Hits         1622     1622           
  Misses        240      240           
Flag Coverage Δ
#unittests 87.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7d81e...65ca2fa. Read the comment docs.

@shyamd shyamd requested a review from ml-evs March 25, 2020 15:48
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and fixes my problems, thanks @shyamd.

@ml-evs ml-evs merged commit 7768f62 into Materials-Consortia:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local testing fails without default config
2 participants