Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adapters - Base design + 'structures' (+ 'references'... sort of) #241
Add adapters - Base design + 'structures' (+ 'references'... sort of) #241
Changes from 30 commits
fbe83dc
b906860
0effe72
109496c
a6c4b18
a8efec2
39137a1
741e5b1
0aed01e
572a277
ef420ff
e882b8b
97bdefb
2c71a11
c7ccc28
ad45225
68cc650
7fd4cf5
6704c0b
2c7aa92
f419565
322ab54
2deae37
50d7cd8
7cee376
3ad0e28
b71b2ce
71e69ca
ca6f4ae
6baf226
f2f2b4d
f88df44
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, this dictionary might become an instance of a
ConverterCollection
class that could include checks on the interface of the functions it contains etc.For the moment, this is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea. And definitely one for the future, i.e., not something I will explore at this time.